osompress / simple-social-icons

Plugin: Simple Social Icons
62 stars 33 forks source link

Undefined offset: simple-social-icons.php:405 #12

Closed ctalkington closed 7 years ago

ctalkington commented 9 years ago

with WP_DEBUG on it looks like the code to build css creates a notice when no instances are setup.

$instance = wp_parse_args( $all_instances[$this->number], $this->defaults );
rrennick commented 9 years ago

@nathanrice this one is ready for testing.

bgardner commented 7 years ago

@rrennick Better late than never. Do you think this code is still good based on the 2.0 update the plugin recently was given?

cc: @dreamwhisper @nathanrice

rrennick commented 7 years ago

It looks like it's already there - https://github.com/copyblogger/simple-social-icons/blob/develop/simple-social-icons.php#L419

bgardner commented 7 years ago

So it's in there already, and we can close this issue?

rrennick commented 7 years ago

Yes & closing.