search

osompress / simple-social-icons

Plugin: Simple Social Icons
62 stars 33 forks source link

Update plugin stylesheet version #18

Closed nickcernis closed 8 years ago

nickcernis commented 8 years ago

The plugin stylesheet is currently enqueued as version 1.0.5 even though the plugin version is 1.0.10:

wp_enqueue_style( 'simple-social-icons-font', esc_url( $cssfile ), array(), '1.0.5', 'all' );

(From https://github.com/copyblogger/simple-social-icons/blob/develop/simple-social-icons.php#L393 )

As a result, CDNs, caching plugins, and web browsers aren't using the new stylesheet with the icomoon font – they're still caching the old stylesheet that references the previous fontello fonts, which are no longer part of the plugin. Because of this, icons are disappearing for some users who upgrade until they purge site caches, CDNs, and browser caches manually.

I propose either updating the version during each plugin release manually or using the current plugin version automatically. This should help with future releases if new icons are added to the font too.

nickcernis commented 8 years ago

Thanks for the quick fix, @nathanrice!