Consider changing the default styles filter for v2.0?

[robincornett]

With the significant changes to the markup, beyond just the change to using SVG, themes which have used the simple_social_default_css filter to override the plugin stylesheet will experience significant styling issues.

Since the simple_social_default_glyphs filter is being removed/replaced in 2.0, I'd like to suggest that the stylesheet filter be treated similarly. Although it may cause some minor styling issues, I think it would be a lot less destructive than leaving it in, for those who have used it. Simply changing the filter hook name seems like it should be sufficient.

[mjsdiaz]

I would also like to see the simple_social_default_css filter changed, as Robin recommends.

[bgardner]

Assigning to @laurenmancke and wanted to get feedback from @dreamwhisper from a support perspective.

[robincornett]

Here's a visual example of 2.0 with a theme using the default glyphs and default styles filters: Since the glyphs are deprecated, it's using the new SVGs and all markup, but the old CSS, which obviously does bad things. Tweaking the filter hook name resolves everything.

Thank you for looking into this--much appreciated.

[dreamwhisper]

@bgardner I would agree with @robincornett that we should rename the filter.

[bgardner]

Go with something like simple_social_default_css_deprecated?

[robincornett]

Why not simple_social_default_stylesheet, since it's still available if someone wants to use it in 2.0? And it is modifying a stylesheet URL?

[bgardner]

I'm good with that. cc: @laurenmancke

[bgardner]

Actually, @robincornett if you were up for issuing a PR on this, we can have @nathanrice merge it. This way I have the pleasure of adding you to the props section when I update the StudioPress post. ;-)

[bgardner]

Or I can. :-P