search

osompress / simple-social-icons

Plugin: Simple Social Icons
62 stars 33 forks source link

Added plugin_version() method to return plugin version from header me… #40

Closed blogjunkie closed 7 years ago

blogjunkie commented 7 years ago

The previous versions of the plugin hard-coded the version number 1.0.12 in the wp_enqueue_style() function. This caused lots of caching issues and broken display of the icons e.g.

https://wordpress.org/support/topic/update-to-2-0-borked-existing-icons/ https://wordpress.org/support/topic/update-2-0-ruined-plugin/

I added a plugin_version() method to return the plugin version from the header metadata and used that in wp_enqueue_style() instead.

This is my first ever pull request so please explain it like I'm 5 if you have feedback. Thank you!

bgardner commented 7 years ago

I would love to see what @rrennick and @nathanrice think about this. if it's good, I've love to include this in the update as we've had a number of caching issues.

bgardner commented 7 years ago

@rrennick Would it take long for you to write code/issue a PR to cover this in concept?

rrennick commented 7 years ago

@bgardner no, I'll submit one in a few minutes.

bgardner commented 7 years ago

Closing this via https://github.com/copyblogger/simple-social-icons/commit/002716b44e6e2ed19bd45d58f2e11dfe90d59c7b

blogjunkie commented 7 years ago

Thank you @rrennick & @bgardner !