osompress / simple-social-icons

Plugin: Simple Social Icons
62 stars 33 forks source link

[simple-social-icons] shortcode #50

Open nickcernis opened 7 years ago

nickcernis commented 7 years ago

We've seen repeated requests in the WP.org forums for a Simple Social Icons shortcode to output icons within a post.

https://wordpress.org/support/topic/shortcode-477/

May require the addition of a global settings page like we have in Simple Share.

marksabbath commented 6 years ago

Hey @nickcernis since this is a widget, what do you think about using an approach like amr-shortcode-any-widgetplugin? Is there any suggestion in your mind related to this?

nickcernis commented 6 years ago

@marksabbath How do you feel about putting this issue into backlog for now?

It looks like a dedicated shortcode would be a bigger project (requires plugin restructuring and a custom admin page). I'm not sure the utility a shortcode offers is worth it right now in light of Gutenberg. A Gutenberg block may be more useful once that becomes available as an option to us.

If the amr-shortcode-any-widget plugin works as an alternative, we could suggest that as a workaround for now for those asking.

cc @mattlawck @dreamwhisper

marksabbath commented 6 years ago

Sounds like a reliable plan @nickcernis and I do agree that maybe, a Gutenberg block would be way more useful than a shortcode at this point.

Let's wait for @dreamwhisper and @mattlawck thoughts :)

Thanks for your help man!

mattlawck commented 6 years ago

I agree with that, if its a large feature that doesn't yet exist, should probably be the focus of its own version?

marksabbath commented 6 years ago

Yeap, maybe a version focused on this feature would make more sense. Moving it to backlog. Thanks guys!

cinghaman commented 4 years ago

Since Gutenberg block has been there for a while, any chance for adding social icons to Gutenberg block?