osompress / simple-social-icons

Plugin: Simple Social Icons
62 stars 33 forks source link

SVG (and other URLs) #67

Closed mattlawck closed 6 years ago

mattlawck commented 6 years ago

This was submitted to Nathan direct:

On a site with HTTPS/SSL

A file with an insecure url of "http://www.acupuncture-answers.com/wp-content/plugins/simple-social-icons/symbol-defs.svg" was loaded via the javascript file: https://www.acupuncture-answers.com/wp-content/plugins/simple-social-icons/svgxuse.js?ver=1.1.21 on line 172. The insecure URL may not be directly contained in the script file and may exist elsewhere.

You may need to contact your web hosting provider for assistance.

This URL will need to be updated to use a secure URL for your padlock to return.

I would be happy to edit the images we're using for the SS plugin, however, the option to edit the icons/urls etc is now gone from our dashboard.

nickcernis commented 6 years ago

We could prompt them to check that the site's WordPress URL and Site URL start 'https://' and not 'http://' at Settings → General.

mattlawck commented 6 years ago

Confirm we aren't referencing as http

marksabbath commented 6 years ago

Simple Social Icon uses plugin_dir_url to look for URLs inside the WordPress, which automatically builds the scheme according to is_ssl() WordPress function. I've tested it on a regular WordPress install with and without SSL and both are working accordingly.