osompress / simple-social-icons

Plugin: Simple Social Icons
62 stars 33 forks source link

Missing rel="noopener" on links with target="_blank" #71

Closed NormanHoehne closed 5 years ago

NormanHoehne commented 6 years ago

Dear team,

you should add rel="noopener" for all links that open in a new window to improve security and performance.

Please take a look at:

Chrome has fixed this vulnerability long time a go, but e.g. firefox is still vulnerable.

Cheers, Norman

nickcernis commented 5 years ago

To test (feature/noopener branch):

Confirm:

dreamwhisper commented 5 years ago

@nickcernis ready to merge!

nickcernis commented 5 years ago

@dreamwhisper Merged in https://github.com/studiopress/simple-social-icons/pull/85. Thanks for looking at this!