search

osompress / simple-social-icons

Plugin: Simple Social Icons
62 stars 33 forks source link

Removed HTML content from SVG. #74

Closed marksabbath closed 6 years ago

marksabbath commented 6 years ago

Fixed medium logo.

marksabbath commented 6 years ago

Hey, @nickcernis would you mind taking a look at this PR, just in case?

Thanks in advance! :)

nickcernis commented 6 years ago

I documented how to update the icons here: https://github.com/studiopress/simple-social-icons/wiki/Development-info:-updating-existing-logos.

New Medium logo in place:

customize__wp_dev_ _just_another_wordpress_site
marksabbath commented 6 years ago

Not at all @nickcernis thanks for all the help!

Hey, @marksabbath! On testing, I found that the new logo needed adjustment to work with our icon and background color pickers. I hope you don't mind that I've pushed that change to this branch. I also added it to symbol-defs.svg, which is the combined/optimised file that's loaded on the front end. I'll add a note to our Wiki with the steps I took in case this comes up again.