Adding an option to remove the css output.

osompress / simple-social-icons

Plugin: Simple Social Icons

62 stars 33 forks source link

Closed marksabbath closed 6 years ago

marksabbath commented 6 years ago

Should fix #56

marksabbath commented 6 years ago

Hey, @nickcernis If I'm not mistaken, this pull request should resolve #56

Would you mind reviewing it?

Thanks in advance :)

marksabbath commented 6 years ago

It totally makes sense to me @nickcernis

I've made those changes since the user in the thread was complaining directly about that code, and thought it could be useful.

I'm more than happy to create a filter to remove all the CSS if it would be better, just let me know and I'll be promptly working on this :)

susannelson commented 6 years ago

@nickcernis I agree it would be better to make a filter instead of an option in the widget.

My only thought is that users might be confused about why there are no settings available in the widget when they see them mentioned in KB articles.

As you said, it would be up to the theme developers to make it clear about why the regular settings aren't available. :)

nickcernis commented 6 years ago

@marksabbath @susannelson Thanks for the feedback on this. It looks like the path forward is:

Add a filter named “simple_social_disable_custom_css” or similar (value is false by default).
If true:
- Disable output of custom CSS in the css() function. (enqueue_css() already has its own filter.)
- Disable output of all styling fields in form().
Mention in the filter docs that theme developers should warn their users about missing options. (“If setting this filter to true, we recommend mentioning in your theme documentation that Simple Social Icons widget settings will have display styling options, as your theme styles icons for them.”)

marksabbath commented 6 years ago

Closing, should be addressed by #80