Add rel=nofollow to the links.

osompress / simple-social-icons

Plugin: Simple Social Icons

62 stars 33 forks source link

Add rel=nofollow to the links. #77

Closed marksabbath closed 6 years ago

marksabbath commented 6 years ago

Should fix #59

marksabbath commented 6 years ago

Hey, @nickcernis I think that adding rel="nofollow" to all the links would be the best approach, right?

Would you mind reviewing this?

Thanks in advance :)

marksabbath commented 6 years ago

@nickcernis what about adding a new checkbox to allow the user to have control in the WordPress backend, without a necessity of adding any extra code?

nickcernis commented 6 years ago

@marksabbath I checked help desk for other requests for nofollow in Simple Social Icons, but couldn't find anything. Since we don't see many requests for it we might not need the checkbox just yet.

Do you think a filter would suffice for now? One plus is it also allows people to add 'rel=me' and other attributes if they want.

davidcolden commented 6 years ago

Sorry I'm late to comment on this...

I feel it would also be good if we could have "noopener" included as well on the rel if the setting is to open the links in a new window.

This is for a number of reasons...

the new page runs on the same process as your page so If the new page is executing expensive / large javascript calls potentially the calling page's performance will also be impacted...
opening links (with target="_blank") is also a security vulnerability as the new page has access to your window object via window.opener.

This would also potentially give an uplift from a Google perspective as it's one of their best practices for improving quality in a site.

nickcernis commented 6 years ago

Thanks for your feedback, @davidcolden. You bring up a good point, and I've opened a new issue for this (https://github.com/studiopress/simple-social-icons/issues/78) to track in a future update, since it's more closely related to the “open links in new window” behaviour than the nofollow being discussed here.

People could potentially add noopener via the above filter if they wanted to in the meantime, though.

marksabbath commented 6 years ago

Closing this one. Filter implemented on #79.