osompress / simple-social-icons

Plugin: Simple Social Icons
62 stars 33 forks source link

multiple instances on single page #8

Closed ctalkington closed 6 years ago

ctalkington commented 10 years ago

the style selector used causes issues on pages with multiple instances.

would suggest selector that uses widget id. will open PR if come up with solution.

dreamwhisper commented 9 years ago

Debatable whether this should have a separate issue, but inactive widgets also cause a problem. CSS output comes from the last widget added regardless of whether the widget is active.

Many people don't think to look in the inactive widgets area when trying to determine why their settings aren't updating the front end.

ctalkington commented 9 years ago

semi related is #12 which causes php notice when no widgets are setup.

carasmo commented 7 years ago

+1

carasmo commented 6 years ago

+1 -- It's not logical for most users to see the ability to style the icons and then have their header icons (in a light background, for example), take on the style of the footer icons which went on a dark background.

carasmo commented 6 years ago

https://github.com/copyblogger/simple-social-icons/pull/60

marksabbath commented 6 years ago

Fixed by #60