search

osompress / simple-social-icons

Plugin: Simple Social Icons
62 stars 33 forks source link

Regenerate fonts with icomoon (fixes Android glitch) #9

Closed nickcernis closed 9 years ago

nickcernis commented 9 years ago

Fonts generated by fontello result in missing glyphs in the stock Android browser (issue #7 ). This PR includes an updated font regenerated with icomoon that fixes this issue.

I tried to regenerate the icon pack with fontello using different glyph codes. The Facebook icon reappears, but other glyphs are then absent:

screen_shot_on_2014-12-21_at_12-52-56

The fontello developer appears to be aware of the issue but doesn't believe it to be a problem with fontello: #204. I've tried deleting the woff file as suggested to force Android to fall back to the ttf, but the Facebook icon is still missing. I'm using Private Use Area encoding (most compatible).

Using icomoon to generate an icon font containing the same glyphs works in Android, iOS, and all desktop browsers tested (including IE 8-to-11).

screen shot on 2014-12-21 at 18-30-26

The selection.json file is included so that the kit can be added to using the in-browser icomoon app.

Free in-browser Android emulators are available here if required: https://www.manymo.com/emulators

nathanrice commented 9 years ago

@rafaltomal can you take a look at this?

rafaltomal commented 9 years ago

I tested it and seems to work fine.

Thanks @nickcernis!

bgardner commented 9 years ago

@nathanrice If you can, will you merge, update and push to WP.org?