osopromadze / Spring-Boot-Blog-REST-API

Restful CRUD Blog API using Spring Boot, Spring Security, JWT, Mysql, JPA
GNU Affero General Public License v3.0
758 stars 333 forks source link

Request for Test Addition #57

Open alidehkhodaei opened 1 year ago

alidehkhodaei commented 1 year ago

Hello and thank you for this project!

I believe it would be great to have tests written for this project. Is it possible to add tests?

Having tests can greatly improve the overall quality and stability of the project. It allows for easier maintenance, prevents regression bugs, and helps ensure that the project behaves as expected in different scenarios.

github-actions[bot] commented 1 year ago

Welcome @alidehkhodaei to Spring-Boot-Blog-REST-API community! Thanks so much for creating your first issue :)

osopromadze commented 1 year ago

Hi @alidehkhodaei, I started working on this project when I was learning and did not write tests :smile: For now I did not touch it long time.

Feel free to add tests if you would like.

zachary-berdell-elliott commented 10 months ago

Hi, I was going backwards through codetriage.com to find a repo I could start contributing to. I saw this one and thought I would take a look.

I currently work as a Java and Spring developer. This issue seems like something I could pick up. I know a few things about writing good unit tests with JUnit.

Is this repo still actively maintained? If so, I wouldn't mind picking this up.

zachary-berdell-elliott commented 10 months ago

I was going to ask what the rules are for contributing and forked this repo. I guess when I create a PR, it is raised to this repo. I wrote tests for AlbumServiceImpl and will continue to write tests for more classes even if this repository is no longer maintained just for fun. https://github.com/osopromadze/Spring-Boot-Blog-REST-API/compare/main...zachary-berdell-elliott:Spring-Boot-Blog-REST-API-tests-added:feature/add-junit-tests?expand=1

zachary-berdell-elliott commented 9 months ago

I have added unit tests for most logical code. There may still be a few cases that need to be covered though. I also fixed a bug that I found with the deleteUser method in UserServiceImpl. If this repository is still maintained or if someone stumbles across this repository and wants to work on it, feel free to merge these changes.

vherak commented 3 months ago

!assign