ospalh / anki-addons

A collection of Anki 2.1 addons in different states of bugginess, up-to-dateness and usefulness.
http://ospalh.github.io/anki-addons/
135 stars 60 forks source link

OALD url #70

Open Jimmy-Z opened 9 years ago

Jimmy-Z commented 9 years ago
'http://www.oxfordlearnersdictionaries.com/search/english/?q='

would be better than:

'http://www.oxfordlearnersdictionaries.com/definition/english/'

for example: 'Japan' via 1st URL vs 'Japan' via 2nd URL

Jimmy-Z commented 9 years ago

and OAAD, I know you've said you'll probably not add any more English downloaders.

like Heimlich maneuver,

oaad.py:

# download pronunciations from Oxford Advanced Learner's Dictionary

from .oald import OaldDownloader

class OaadDownloader(OaldDownloader):
    def __init__(self):
        OaldDownloader.__init__(self)
        self.url = \
                'http://www.oxfordlearnersdictionaries.com/search/american_english/?q='
        self.extras['Source'] = u'Oxford Advanced American Dictionary'
Jimmy-Z commented 9 years ago

you mentioned OAAD in this part of the manual, but actually only OALD is included.

ospalh commented 9 years ago

Well, OAAD, OALD, who can keep them apart. I’ll think about this. Btw, you get Heimlich maneuver from MW and Japan from lots of sites.

Jimmy-Z commented 9 years ago

I know, I know...

ospalh commented 9 years ago

And the chances i’ll publish the changes are better when you make a pull request. (But i guess i will not have OAAD and OALD activated by default, similar to American,British} Macmillan) And please

ospalh commented 9 years ago

Btw, i am not doing anything for this. If you want this in the main version, please make a pull request.