search

osparcomm / HARSAT

Harmonized Regional Seas Assessment Tool
https://osparcomm.github.io/HARSAT/
Other
0 stars 5 forks source link

Webservice: missing country in station webservice download #227

Open RobFryer opened 1 year ago

RobFryer commented 1 year ago

The station dictionary download from the webservice contains a station (133773) with a missing country and a station name TestBulkUpload.

This station also has both a HELCOM area and an OSPAR area, but it is in the Kattegat, so maybe this is correct.

morungos commented 1 year ago

@RobFryer Should we close this? It's been marked as invalid and split into a separate issue.

RobFryer commented 12 months ago

@morungos The issue is still current (the last time I checked). I have asked Hans Mose and it is an error in the extraction of the station dictionary from the ICES webservice. Fortunately it doesn't impact anything in the harsat code. I will chase Hans to resolve it. (It is just a single issue - the relevant station was created for testing purposes and needs to be removed.)

HansMJ commented 2 months ago

@RobFryer @morungos I think we have talked about this already. In the ICES station dictionary vocab there are a few test cases/examples. These stations are flagged as deprecated. So the station_deprecated field of the download is '1'.

If a station is flagged as deprecated they should not be used with data. A solution could be to

  1. Remove deprecated stations from the xhat web-service download or
  2. Insert it as an option when calling the web-service to include deprecated stations or not

Would this work for you and if so, which one do you prefer?

HansMJ commented 1 month ago

@RobFryer Just to confirm after our talk yesterday. All these test stations are now flagged as deprecated in the station dictionary (and XHAT downloads)