search

osparcomm / HARSAT

Harmonized Regional Seas Assessment Tool
https://osparcomm.github.io/HARSAT/
Other
0 stars 5 forks source link

The symbology in the summary tables generic, applicable to all situations #411

Closed hansmy closed 10 months ago

hansmy commented 10 months ago

To temporarily remove the symbology from the summary tables for the initial release. Note there is still some work/ thinking to make it fully generic, and thus to be safe, the current symbology could be omitted until further, than using presenting symbols that work most of the time.

morungos commented 10 months ago

After discussion with @swamap, I'd suggest that symbology is, for now, retained but deprecated. One solution would be to add a new parameter, symbology, defaulting to FALSE, that, if true, maintains the output as it stands today. This would allow users (such as, maybe, @HansMJ) who might be depending on the symbology to continue using the package without loss until the new fully generic system is implemented.

hansmy commented 10 months ago

The solution to add a new parameter, symbology, defaulting to FALSE, that, if true, maintains the output as it stands today. Agreed, this sounds like a very good interim solution, let us do that.

RobFryer commented 10 months ago

I'll take this on and have a look at it today / tomorrow