osparcomm / HARSAT

Harmonized Regional Seas Assessment Tool
https://osparcomm.github.io/HARSAT/
Other
0 stars 5 forks source link

estimate of prtrend - trap pathological case #436

Closed RobFryer closed 9 months ago

RobFryer commented 9 months ago

prtrend is the p-value associated with the 'recent trend' - typically the trend in the last 20 years

A pathological case occurs when:

In this case, the fitted values are all the same, the recent trend is estimated to be zero, and yet prtrend is highly significant. This arises because prtrend is pickup from p_linear. In this case, it makes sense to obtain prtrend from the contrasts, which will give a value of unity (i.e. no evidence of any trend).

There is a more general issue here, related to the definition of recent trends. This can be dealt with in the release after next. I'll raise an issue.