search

osparcomm / HARSAT

Harmonized Regional Seas Assessment Tool
https://osparcomm.github.io/HARSAT/
Other
0 stars 5 forks source link

graphics: sploms and ratio plots #477

Closed RobFryer closed 3 months ago

RobFryer commented 3 months ago

Issue #409

Have updated the functions plot_multiassessment, plot_multidata and plot_ratio so that they are compatible with the harsat code. (They haven't been used with harsat before - only had a pre-harsat existence.)

I also fixed one minor bug in ctsm.web.getKey

Have tested them minimally, but thorough testing is not critical at this stage because they are not currently used and not exported.

I will do a lot more testing when they are activated within the markdown that generates a report for each time series. This will happen soon (before the next release).

I was originally going to write an exported wrapper function (along the lines of plot_assessment) for these internal functions, but I won't have time before the next release. They will therefore only be accessible by the markdown and by people who want to delve deeply into the code.

RobFryer commented 3 months ago

@annelaerkes @hallareinert Please could one of you review and, if happy, merge. There should be no conflicts with the other pull request. If there are, then please get in touch. Thanks!