Partial Equilibrium parameters not working in TB

[GoFroggyRun]

Under the same reform (available here), I implemented the partial equilibrium functionality in TB (available here), and it seem that this PE function is not working at all:

Note that, from the two tables above, TB yields almost identical result with or without PE assumption, which is not the case for TC, nor dropQ local.

So my guess is that PE options are not being properly implemented in TB.

cc @MattHJensen

[MattHJensen]

Confirmed. Thanks @GoFroggyRun

[GoFroggyRun]

It seem that, in the latest TB (test) release, taxable income and capital gains parameters under partial equilibrium sector are working just fine (thanks @brittainhard for fixing this!), while two parameters in Charitable Contributions section are not.

The issue is that, when you input any valid parameter to any of the charitable contribution variable, the calculator will keep running. At least I wasn't able to finish any calculation involving charitable assumptions so far.

cc @MattHJensen @brittainhard

[MattHJensen]

could you take a screenshot of the parameters that aren't working?

On Apr 3, 2017, at 3:08 PM, Sean.Wang notifications@github.com<mailto:notifications@github.com> wrote:

It seem that, in the latest TB (test) release, taxable income and capital gains parameters under partial equilibrium sector are working just fine, while two parameters in Charitable Contributions section are not.

The issue is that, when you input any valid parameter to any of the charitable contribution variable, the calculator will keep running. At least I wasn't able to finish any calculation involving charitable assumptions so far.

cc @MattHJensenhttps://github.com/MattHJensen @brittainhardhttps://github.com/brittainhard

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/OpenSourcePolicyCenter/webapp-public/issues/512#issuecomment-291242992, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH6qJBh8JPsfYhC4VLLnP4EIr5YPCBSeks5rsUO_gaJpZM4Mfyki.

[GoFroggyRun]

@MattHJensen :

[MattHJensen]

We don't need to include those parameters for now. @brittainhard, is it trivial to drop them?

On Apr 3, 2017, at 3:27 PM, Sean.Wang notifications@github.com<mailto:notifications@github.com> wrote:

@MattHJensenhttps://github.com/MattHJensen : [screen shot 2017-04-03 at 3 27 03 pm]https://cloud.githubusercontent.com/assets/13324931/24627226/0b2071e4-1882-11e7-8d6d-731a83b85b4b.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/OpenSourcePolicyCenter/webapp-public/issues/512#issuecomment-291247937, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH6qJDPVRb9KirIPHrVsXthUJAEukY9jks5rsUgsgaJpZM4Mfyki.

[MattHJensen]

Just to be clear, the to dos here is:

• [x] Remove the Charitable Contributions elasticities from the partial equilibrium page.

[brittainhard]

@MattHJensen I can remove them from the form. I'll push a fix.

[MattHJensen]

Resolved. Thanks @brittainhard and @GoFroggyRun