search

ospc-org / ospc.org

Source code for PolicyBrain, ospc.org, and related assets.
MIT License
24 stars 32 forks source link

Downloaded CSV files are not rectangular #885

Closed martinholmer closed 6 years ago

martinholmer commented 6 years ago

When importing a downloaded CSV file into a spreadsheet, it is so distorted it is useless.

The distortion is caused by fact that the first (title) line in the downloaded CSV file is not comma separated. This is strange because the last (source) line is comma separated, as is the body of the table.

What's the schedule for fixing this serious bug?

@hdoupe @GoFroggyRun

hdoupe commented 6 years ago

@martinholmer Thanks for the bug report. I was able to open the CSV in Excel and Numbers (the Apple version of Excel). That being said, this is a CSV and not an Excel spreadsheet. Thus, the odd formatting is not helpful. I'm taking stock of the open issues today and will open an issue to outline PolicyBrain priorities for the near future.

martinholmer commented 6 years ago

@hdoupe said:

I was able to open the CSV in Excel and Numbers (the Apple version of Excel). That being said, this is a CSV and not an Excel spreadsheet. Thus, the odd formatting is not helpful.

Yes, I too can open up the downloaded CSV files in my spreadsheet, but the non-rectangular format leaves the spreadsheet misaligned.

It's not just spreadsheets that will be processing downloaded CSV files. And those other tools will be expecting a rectangular file. That is, one that has the same number of comma-separated values per row. The current TaxBrain CSV files are not like that.

hdoupe commented 6 years ago

Thanks @martinholmer. I agree.

I haven't done anything with the CSV file code before. I'm having trouble figuring out where they are even created. @GoFroggyRun are the CSV files built with javascript?

GoFroggyRun commented 6 years ago

@hdoupe yes. These buttons are within the datatables.js file. And the function related to CSV output button can be found here.

hdoupe commented 6 years ago

@martinholmer #885 should have been fixed in PR #904. Are you interested in testing out this fix? You can verify it at https://ospc-test.herokuapp.com/

martinholmer commented 6 years ago

@hdoupe said:

885 should have been fixed in PR #904. Are you interested in testing out this fix? You can verify it at https://ospc-test.herokuapp.com/

Sorry, I don't have time.

hdoupe commented 6 years ago

Ok, closing #885.