search

ospc-org / ospc.org

Source code for PolicyBrain, ospc.org, and related assets.
MIT License
24 stars 32 forks source link

PEP8 fixes #919

Closed lucassz closed 6 years ago

lucassz commented 6 years ago

PEP8 fixes, done using autopep8 and a lot of manual tweaking for more intuitive indentation than the automated tool gives. I'm looking forward to discussion about the advantages and disadvantages of this. The main possible disadvantage is that it makes code history less easily navigable using Git. The main advantage is that this would bring us to an equilibrium point of maximum readability, and it would not be strenuous after that to make sure that new commits still follow the standard, so it would be a one-time adaptation.

lucassz commented 6 years ago

@hdoupe Thanks for the catch, I fixed a few merge conflicts and amended the commit. I had to do a lot of manual merging because I was first working on top of #917, then realized it was probably better to separate the two until the other one is merged.

hdoupe commented 6 years ago

@lucassz this looks great. Thanks for putting so much effort into cleaning up the PolicyBrain code base in PR #919 as well as the previous PR's you've put up.

I expressed some reservations about doing this type of fix when discussing this off-line. While I am still concerned about overwriting the code history, I think the code-readability improvements outweigh these concerns. Further, we can add code style tests to travis to ensure that this is a one-time occurrence. That way we don't need to overwrite code history like this in the future.

hdoupe commented 6 years ago

Thanks for the contribution @lucassz