search

ospc-org / ospc.org

Source code for PolicyBrain, ospc.org, and related assets.
MIT License
24 stars 32 forks source link

Update to Tax-Calculator 0.22.2 #939

Closed hdoupe closed 5 years ago

hdoupe commented 6 years ago

This PR updates PolicyBrain to Tax-Calculator 0.22.2. I hope to resolve https://github.com/ospc-org/ospc.org/issues/770 with this PR, too.

Everything looks good with the update except that there's an issue installing taxpuf. I'm going to keep tinkering with that and then take a look at resolving #770.

cc @martinholmer @MattHJensen

hdoupe commented 6 years ago

I referred to 0.20.2 instead of 0.22.2 in describing this PR, but the changes in the code are correct. That is, Tax-Calculator is updated to 0.22.2.

hdoupe commented 6 years ago

@martinholmer are these all of the columns that are expected for the difference table? screen shot 2018-11-01 at 6 22 00 pm

martinholmer commented 5 years ago

@hdoupe asked in #939:

are these all of the columns that are expected for the difference table?

Yes, it looks like it. There are now two more than there used to be, right? Thanks for fixing this.

hdoupe commented 5 years ago

Yep. No problem, this was a simple fix. It should have been done long ago.

I'll put this on the test server today and try to get it into production tomorrow or on Monday.

hdoupe commented 5 years ago

I plan to merge #939 once the tests pass. The merging of this PR was delayed due to installation complications on the PolicyBrain and the PUF package sides.