ospc-org / ospc.org

Source code for PolicyBrain, ospc.org, and related assets.
MIT License
24 stars 32 forks source link

Zeroes reported on Static Results page #947

Closed siervicul closed 5 years ago

siervicul commented 5 years ago

Beginning sometime yesterday, I've started getting results pages with mostly zeroes in the analysis tables. The "total liabilities by calendar year (change)" table has nothing but zeroes except in the two right-most columns. The difference by expanded income bin table has all zeroes in the "all tax units," "tax units with tax cut," "tax units with tax increase," and "total tax difference" columns.

hdoupe commented 5 years ago

@siervicul ospc.org was updated yesterday to use a new version of Tax-Calculator. I suspect that is why the results are different. Can you post a link to the outputs page that you are referring to?

siervicul commented 5 years ago

@hdoupe here's one, though I have the same result with every reform I try, and regardless of whether I use the PUF or CPS data source--all zeroes in the first table: https://www.ospc.org/taxbrain/37335/

I'm getting the same issue with Internet Explorer on a PC and Chrome on an iOS device.

hdoupe commented 5 years ago

Thanks @siervicul. I can confirm that this is an issue on the ospc.org side and not with Tax-Calculator. Something is happening after the data from Tax-Calculator is processed and when the data is rendered into the table. I'm trying to resolve this now.

hdoupe commented 5 years ago

@siervicul The bug fix for this is live at www.ospc.org. Can you confirm whether the issue has been resolved? Sorry for the delay in getting this up.

I think the explanation for this is that Tax-Calculator has started scaling its own results. Previously, TaxBrain scaled the results down to Billions, Millions, etc.