search

ospc-org / ospc.org

Source code for PolicyBrain, ospc.org, and related assets.
MIT License
24 stars 32 forks source link

TaxBrain distribution/difference table problems #954

Closed martinholmer closed 5 years ago

martinholmer commented 5 years ago

In PolicyBrain 1.7.6, there are still "Thousands" labels that should be "Millions". That is clearly wrong. Not clearly wrong, but questionable is rounding the number of filing units to the nearest whole million instead of to the nearest one-tenth of a million or to the nearest one-hundredth of a million.

screen shot 2019-01-14 at 3 13 53 pm

The bug in the decile tables (all zeros on the 0-10n and the 0-10z rows) is caused by a Tax-Calculator bug that was fixed in Tax-Calculator pull request 2192.

hdoupe commented 5 years ago

@martinholmer which columns should have which units? I'll swap them out once I have this info.

hdoupe commented 5 years ago

@martinholmer said:

The bug in the decile tables (all zeros on the 0-10n and the 0-10z rows) is caused by a Tax-Calculator bug that was fixed in Tax-Calculator pull request 2192.

Hmm, this may be harder to fix. Will this patch be released before the release that drops the Behavior class?

martinholmer commented 5 years ago

@hdoupe asked:

Will this patch [T-C PR #2192] be released before the release that drops the Behavior class?

No. See pending release 0.25.0 here.

hdoupe commented 5 years ago

@martinholmer what do you think about applying the 2192 patch to the 0.24 release and doing a 0.24.1 release in addition to the 0.25.0 release? @andersonfrailey and I have been working on a new package that will integrate Tax-Calculator and Behavior-Responses. However, it's not ready for production yet, and I think that the TaxBrain users would value this bug-fix before the new tax integrator package is ready to go.

martinholmer commented 5 years ago

@hdoupe said in issue #954:

I think that the TaxBrain users would value this bug-fix before the new tax integrator package is ready to go.

I don't see how the "value" could be much more than zero given that no TaxBrain users noticed this problem over the past nine months. As noted here the bug has been present since April 19, 2018, when Tax-Calculator 0.19.0 was released.

hdoupe commented 5 years ago

Ok I see. Thanks for the bug report @martinholmer.