search

ospfranco / sol

MacOS launcher & command palette
MIT License
1.92k stars 87 forks source link

Usage of GitHub releases #127

Open SMillerDev opened 2 weeks ago

SMillerDev commented 2 weeks ago

I'm a maintainer for Homebrew, and when working on some style issues in casks I found that this software embeds releases in the repo, which is highly unusual and probably pretty bad for git performance. Would you consider adding the releases to the GitHub releases and tags so they are easier to find for people?

ospfranco commented 2 weeks ago

hey, I think the releases folder was necessary for sparkle, can't remember. The homebrew listing was contributed in a PR so I don't really know how it works.

Moving to releases would be better indeed, but I'm going on vacation next week for 3 months, so I doubt I will get to it.

If you provide me with some docs I can try to take a look when I'm back.

SMillerDev commented 2 weeks ago

Don't worry about the Homebrew part. Nothing is wrong there. Enjoy your holiday, here's an apidoc about release assets for when you return: https://docs.github.com/en/rest/releases/assets?apiVersion=2022-11-28

ospfranco commented 2 weeks ago

The problem is sparkle and the generation of the binaries. I have everything setup on my machine, because it is easy with notarization. Having to setup everything on github actions or even on my machine will be time consuming. Given that this is a hobby project of mine and I make 0 moneys out of it... this will be not my prio... even for this year I guess :)