search

ospfranco / sol

MacOS launcher & command palette
MIT License
1.94k stars 91 forks source link

Text input caret not visible #13

Closed Angelk90 closed 2 years ago

Angelk90 commented 2 years ago

Hi @ospfranco , as you can see from the video when it is in light mode it is not clear whether there is focus or not in an input field.

It also happens in the other input fields, for example weather config api.

In the video it can be seen better below because it is zoomed in, but in reality it is not seen.

https://user-images.githubusercontent.com/20476002/159184122-cbc3ec06-3534-4411-8bf6-0d5517857abf.mov

ospfranco commented 2 years ago

Unfortunately, RN does not allow for detailed customization of the caret

ospfranco commented 2 years ago

I opened a new issue in the RN-macOS repo

https://github.com/microsoft/react-native-macos/issues/1096

needs to be fixed on the framework before it can be fixed here

ospfranco commented 2 years ago

Doubt this will get fixed any time soon, I could create a custom native text input component, but I'm too lazy to do this and this feels like a minor thing, I changed to color to a blue that is not so invisible on the white theme

ospfranco commented 2 years ago

Unfortunately the rn team closed the issue, since this is the "documented" behavior and clearly wrong. They cannot deviate from the RN repo, which means it needs to change on the upstream first and then it can be changed on macOS... which will take years to happen.

I will just leave it as is. Not worth it.