ospfranco / sol

MacOS launcher & command palette
MIT License
1.97k stars 93 forks source link

Top half clipped #46

Closed cosmiclasagnadev closed 2 years ago

cosmiclasagnadev commented 2 years ago

Hi Oscar,

I just downloaded the newest version because I wanted to try out the transparency. Had 1.1.32 before this and it worked fine. Now it seems that the top half of the search is clipped out when I press cmd + k

Screenshots

Screen Shot 2022-07-29 at 2 20 02 PM Screen Shot 2022-07-29 at 2 24 53 PM

Love the app Oscar!

ospfranco commented 2 years ago

cmd + k?

Can you give a bit more details, which macOS version are you using for example? on monterrey it is working fine for me

cosmiclasagnadev commented 2 years ago

Oh my bad, I meant to say cmd + space

I'm using Monterey as well (Ver 12.4)

ospfranco commented 2 years ago

Weird, have you tried restarting the app? Otherwise I will try to take a look over the weekend

cosmiclasagnadev commented 2 years ago

Yeah, I even tried reinstalling it, but to no avail.

Alright, will keep testing it. Thanks!

ospfranco commented 2 years ago

Would be nice if you can provide more details, screen resolution? multiple monitors? m1? etc

cosmiclasagnadev commented 2 years ago

OS: MacOS Monterey 12.4

Chip: Apple M1 Pro

Screen Res: 3024 x 1984 Display Settings is set to Default (it says Looks like 1512 x 982 when looking at the scaled resolution)

Issue occurs both when connected to a second monitor and when not connected. I've also tried restarting the app after connecting it to the monitor and it still happens.

The resolution of the second monitor I plug into is 1920 x 1080.

ospfranco commented 2 years ago

I just tried re-installing 1.1.33 from the releases page and everything is working for me. Any additional info you could give?

Any other value that you might have changed in your system? Always show scrollbars or something?

Edit: I also just tried on a Intel machine, also running Monterrey and cannot find any issue

ospfranco commented 2 years ago

I've released a new version 1.1.34 with a minor native change, maybe it will fix it

cosmiclasagnadev commented 2 years ago

I've updated my Mac to the Monterey 12.5, using your newest version , and it doesn't do that anymore!

Pretty unclear what caused it to malfunction in the first place but I think it's all good now, thanks! :)

ospfranco commented 2 years ago

ah, then it was the macOS version... every release is a bag of bugs nowadays :P anyways, glad to see it is fixed!

etherealsunshine commented 2 years ago

Hi, I'm still having this issue @ospfranco OS: macOS Monterey 12.5

Chip: Apple M1

Screen Res: 2560 × 1600

Any Suggestions on how to fix this? I tried reinstalling through brew and manually installing 1.1.34 Thanks!

etherealsunshine commented 2 years ago

this is how it shows up for me for reference

image
ospfranco commented 2 years ago

I just released a new version (1.1.36) can you try that one?

ospfranco commented 2 years ago

You won't be able to fix this with any settings, it's a problem with RN macOS and the UI view constraints, unfortunately I'm not able to reproduce the issue on my machines so I'm blindly trying stuff to see what fixes it

NickTaylor- commented 2 years ago

1.1.36 still has this issue on my machine (M1 on 12.5).

It looks like the offset may be worse, but its hard to tell.

image
ospfranco commented 2 years ago

If any UIKit expert is out there:

https://github.com/ospfranco/sol/blob/main/macos/sol-macOS/AppDelegate.swift#L67

Any help getting auto constraints to work properly would be appreciated... I'll give a day or so, otherwise revert it to a full size window until I can get it to work properly

ospfranco commented 2 years ago

I've released version 1.1.37, I've removed the blurry window effect (which was causing the window not being properly placed) let me know if you have issues still

etherealsunshine commented 2 years ago

still shows up like this

image
mgussekloo commented 2 years ago

Yup, same here

ospfranco commented 2 years ago

There is a new release 1.1.40 with yet another try to fix the issue, let me know if it works

NickTaylor- commented 2 years ago

That seems to have fixed it 🎉

Thank you so much ❤️

etherealsunshine commented 2 years ago

Yep same here!