search

ospfranco / sol

MacOS launcher & command palette
MIT License
1.92k stars 89 forks source link

Command + comma to open settings #64

Closed s-oram closed 1 year ago

s-oram commented 1 year ago

Many Mac applications use the cmd + , shortcut to open application preferences. Would you be open to a PR that adds this shortcut to Sol?

ospfranco commented 1 year ago

Yep, PRs are welcome

s-oram commented 1 year ago

Thanks, I'll give it a shot 🙂

foss- commented 1 year ago

Why not leave the issue open until the implementation is in place? Until then this will allow other users to subscribe instead of re-filing the same issue falsely as duplicate.

ospfranco commented 1 year ago

I got this working right now, will be there on next release

foss- commented 1 year ago

Verified in 1.1.51. This is a nice addition. I actually tried cmd+, but was confused nothing happened, only to learn much later, that settings indeed existed inside of Sol. So this addition is very welcome.

s-oram commented 1 year ago

Thanks @ospfranco