search

osqp / OSQP.jl

Julia interface for OSQP: The Operator Splitting QP Solver
https://osqp.org/
Other
68 stars 25 forks source link

Support for MOI 1 #106

Open lassepe opened 2 years ago

lassepe commented 2 years ago

OSQP currently pins MOI to 0.10.3. A few days ago, MOI as reached 1.0. It would be great to support MOI 1.0 within OSQP and adjust the compat bounds accordingly.

odow commented 2 years ago

Closed by https://github.com/osqp/OSQP.jl/pull/110

imciner2 commented 2 years ago

Was that all that had to be done to transition to MOI 1.0, or are there other parts that we don't implement that we still need to?

odow commented 2 years ago

Yeah maybe leave this open. There's actually a bunch of issues when I look through the code.

These should all be implemented and fixed: https://github.com/osqp/OSQP.jl/blob/c2ff58bc26faa2e5a4318d5d666e19f9cdab8a61/test/MOI_wrapper.jl#L69-L93

Let me take a look through. I have some time, and it'd be good to fix up OSQP.jl properly for JuMP 1.0.

imciner2 commented 2 years ago

If you could hold off doing any major updates to OSQP.jl for a while that would be appreciated. We are working on rebasing it to work with the updated API and library components that will be in v1 of the C library (hopefully being released soon), and have started those modifications in the vb/develop1 branch on this repo. We are hoping to get everything to a point where we will be ready for v1 of the C library by the end of July, at which point we can merge the interface changes and release a v1 here as well.

imciner2 commented 2 years ago

Alternately, if you want to target the branch we are working on the 1.0 version on, feel free to make more changes. But we don't have the jll it refers to pushed anywhere right now.

odow commented 2 years ago

If you could hold off doing any major updates to OSQP.jl for a while that would be appreciated.

Okay, sure.