osqp / OSQP.jl

Julia interface for OSQP: The Operator Splitting QP Solver
https://osqp.org/
Other
68 stars 25 forks source link

Clean up update! code #12

Closed tkoolen closed 6 years ago

tkoolen commented 6 years ago

I was running into some issues and decided to clean up update!.

Summary:

codecov-io commented 6 years ago

Codecov Report

Merging #12 into master will decrease coverage by 0.61%. The diff coverage is 79.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #12      +/-   ##
=========================================
- Coverage   79.91%   79.3%   -0.62%     
=========================================
  Files           4       4              
  Lines         488     488              
=========================================
- Hits          390     387       -3     
- Misses         98     101       +3
Impacted Files Coverage Δ
src/interface.jl 68.31% <79.66%> (-1.24%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 69d25e7...32730d2. Read the comment docs.

bstellato commented 6 years ago

That's great! Thank you so much for this. The garbage collector changes can give lots of problems in Julia 0.7 and it is good to fix them before it is released.

Everything looks good and the tests pass. I will merge it.