search

osqp / OSQP.jl

Julia interface for OSQP: The Operator Splitting QP Solver
https://osqp.org/
Other
68 stars 25 forks source link

Julia 1.0 fixes #30

Closed tkoolen closed 6 years ago

tkoolen commented 6 years ago

Caused this failure: https://travis-ci.org/tkoolen/Parametron.jl/jobs/424531342#L549.

tkoolen commented 6 years ago

Ah, just noticed this was already part of https://github.com/oxfordcontrol/OSQP.jl/pull/29.

codecov-io commented 6 years ago

Codecov Report

Merging #30 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files           6        6           
  Lines         977      977           
=======================================
  Hits          849      849           
  Misses        128      128
Impacted Files Coverage Δ
src/MathOptInterfaceOSQP.jl 92.65% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3550b57...86514bb. Read the comment docs.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

tkoolen commented 6 years ago

I cherry-picked and squashed commits from the PR branch for #29 instead of using my own commit. I worked around the Interval constructor errors so that we can do the update for the latest version of MOI separately.

@lostella, since I'm using your commits, you still need to sign the CLA. I was surprised by this myself at first, but it's just a standard thing for Apache-licensed projects.

lostella commented 6 years ago

@tkoolen: thanks! CLA is signed.

tkoolen commented 6 years ago

Great, I tagged a new release: https://github.com/JuliaLang/METADATA.jl/pull/17734.