osqp / osqp-matlab

Matlab interface for OSQP
https://osqp.org/
Apache License 2.0
42 stars 25 forks source link

Release 0.6.2 #32

Closed bstellato closed 3 years ago

bstellato commented 3 years ago

Some tests are failing on my mac with Matlab 2020b. In particular, I get

Running unconstrained_tests
ERROR in validate_data: Missing vector l
ERROR in osqp_setup: Problem data validation.

================================================================================
Error occurred in unconstrained_tests/test_unconstrained_problem and it did not run to completion.
    ---------
    Error ID:
    ---------
    ''
    --------------
    Error Details:
    --------------
    Error using osqp_mex
    Invalid problem setup

    Error in osqp/setup (line 275)
                [varargout{1:nargout}] = osqp_mex('setup', this.objectHandle,
                n,m,P,q,A,l,u,theSettings);

    Error in unconstrained_tests/setup_problem (line 32)
                testCase.solver.setup(testCase.P, testCase.q, ...
================================================================================

@gbanjac @goulart-paul could you please double check if it happens for you as well?

gbanjac commented 3 years ago

https://github.com/oxfordcontrol/osqp/pull/283 adds this new check:

  if (!(data->l)) {
# ifdef PRINTING
    c_eprint("Missing vector l");
# endif
    return 1;
  }

Note that unconstrained problems have empty l and u.

bstellato commented 3 years ago

This was introduced in https://github.com/oxfordcontrol/osqp/pull/215. I fixed it

bstellato commented 3 years ago

Tests run on my macbook now.