Cleanup and modernize the wrapper

osqp / osqp-matlab

Matlab interface for OSQP

https://osqp.org/

Apache License 2.0

42 stars 25 forks source link

Cleanup and modernize the wrapper #52

Closed imciner2 closed 9 months ago

imciner2 commented 10 months ago

Various modernizations and cleanups to the OSQP mex function and wrapper class.

Improve readability and maintainability of the Matlab class by breaking functions into separate files
Simplify code sections for getting OSQP constants
Expose rho update in a nicer way
Introduce a better and more automated wrapper for the various structs used by OSQP
Introduce wrappers for copying/cloning vectors cleanly

imciner2 commented 9 months ago

The only confusing thing in my opinion is that the installation instructions in the readme file are not updated.

Are you referring to the ones linked to from the readme that are hosted online? We need to update those in the main OSQP repo to fix that once this is all merged.

AmitSolomonPrinceton commented 9 months ago

The only confusing thing in my opinion is that the installation instructions in the readme file are not updated.

Are you referring to the ones linked to from the readme that are hosted online? We need to update those in the main OSQP repo to fix that once this is all merged.

Both it and the instructions in the package directory.

imciner2 commented 9 months ago

Both it and the instructions in the package directory.

Yea, the packaging script needs a rework to do a package builder to make distribution easier.