fix: replace np.int alias with builtin int

osqp / osqp-python

Python interface for OSQP

https://osqp.org/

Apache License 2.0

109 stars 41 forks source link

fix: replace np.int alias with builtin int #105

Closed marvinvanaalst closed 1 year ago

marvinvanaalst commented 1 year ago

This changes the np.int alias of the Python builtin int type as the alias was deprecated in numpy version 1.20.0 and lead to an AttributeError starting with version 1.24.0.

This should fix issue #104

CLAassistant commented 1 year ago

All committers have signed the CLA.

CLAassistant commented 1 year ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

vineetbansal commented 1 year ago

@marvinvanaalst, and sorry for the delay in getting to this, and thanks a bunch for the PR.

2 things before we merge this in:

Can you undo the change in pyproject.toml regarding the black configuration? (since its outside the scope of this PR).
It looks to me like the alias np.int pointing to int has been in numpy since version 1.7, the current min. version of numpy for osqp. So while I agree that np.int should be replaced with int, there's no need to bump up the required numpy version. If you can change that back in requirements.txt that would be the right thing to do.

vineetbansal commented 1 year ago

@marvinvanaalst - after approving PR #109 with this fix, I'm closing this PR. Release v0.6.2.post9 of osqp incorporates these changes. Thanks for bringing this to our attention!