search

osqp / osqp-python

Python interface for OSQP
https://osqp.org/
Apache License 2.0
109 stars 41 forks source link

Fixed tests on scipy 1.12 #150

Closed enzbus closed 2 months ago

enzbus commented 3 months ago

Hello. I actually already fixed issue #149. It was quite easy in fact. Most of the broken tests could be fixed by transposing the random matrices. For about half of them instead I don't know if it was possible to fix them, because the random matrix was rectangular. I added pytest pragmas to skip them. Can you please merge? Thanks.

CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

enzbus commented 3 months ago

And please consider my CLA signed, @bstellato knows me. Thanks.

bstellato commented 3 months ago

Thanks @enzbus for looking into this. I do not think it is a good idea to make such changes. I wrote a longer detailed comment in the issue: https://github.com/osqp/osqp-python/issues/149#issuecomment-2228722932

vineetbansal commented 2 months ago

As per discussion on issue #149 (which I agree with), this PR is closed in favor of PR #151. We'll live with the fact that tests fail if scipy version is 1.12.0, but direct our wheel building logic (cibuildwheel) to ignore the offending scipy version if it encounters one.