search

osqp / osqp-python

Python interface for OSQP
https://osqp.org/
Apache License 2.0
109 stars 41 forks source link

As/v0.6.x.scipy #151

Closed AmitSolomonPrinceton closed 2 months ago

AmitSolomonPrinceton commented 3 months ago

Forbid scipy 1.12.0 only in dev.

vineetbansal commented 2 months ago

Some changes in commit 55260f7 - newer cibuildwheel versions (probably the build package under the hood) insist on specification of some package metadata in pyproject.toml instead of the build-tool specific configuration (setup.py), and specifying the key in dynamic if we do pass in the option to setup.py. We should probably have been doing that anyway, and I see no harm in doing that going forward.

In any case, with these changes, cibuildwheel is working locally, so hopefully it should work in the CI too.

Other changes include addition of scipy pinning in requirements.txt (these are the runtime dependencies in the v0.6.x versions), and removal of the scipy pinning in pyproject.toml (since scipy is not a build time dependency at all).

I feel like the build-backend should be the first key in the build-system section since that's the most important piece of information

enzbus commented 2 months ago

@vineetbansal , however that has no effect, you still have scipy>=1.13.2 in the requirements. I think that's a typo, can you please remove that? I think you can completely unpin scipy

enzbus commented 2 months ago

Ops, my bad, that's a 0.13.2. Thanks so much!!