osqp / qdldl

A free LDL factorisation routine
Apache License 2.0
79 stars 39 forks source link

Make QDLDL.jl compatible to Julia v0.7/1.0 #13

Closed migarstka closed 6 years ago

migarstka commented 6 years ago

A few changes to make QDLDL.jl work with Julia v0.7/1.0. One thing I noted is that the AMD package hasn't been updated to work with Julia v0.7/1.0 yet. Accordingly:


CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

goulart-paul commented 6 years ago

@migarstka Can you check the AMD package and see if they are 1.0 compliant yet? If so I think we should restore amd as the default and them merge this. If not then we should continue to wait.

migarstka commented 6 years ago

I think we can remove this pull request. I tested the QDLDL.jl file in the jl1.0 branch (commit: e474811db411d43d). It uses AMD by default and works under Julia v1.0. We should instead merge the files from that branch into master.

goulart-paul commented 6 years ago

Don't you want to keep the unit testing though, plus all of the changes that are there that make it 1.0 compatible. For example, it seems like it should be necessary to use SparseArrays now. Also you appear to have modified the parametric types in the functions to fit the 1.0 style and added some unit tests.

The only thing that should not be included is the removal of amd and the change to the default ordering method.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 100


Totals Coverage Status
Change from base Build 97: 0.0%
Covered Lines: 82
Relevant Lines: 82

💛 - Coveralls