search

osqp / qdldl

A free LDL factorisation routine
Apache License 2.0
79 stars 39 forks source link

Gate the library products behind CMake flags and some CMake cleanup #38

Closed imciner2 closed 3 years ago

imciner2 commented 3 years ago

When QDLDL is included in OSQP, only the object library is used and the libraries and executables can actually pose issues when compiling for embedded targets.

Also, cleanup the CMake file a little bit by exposing the other compile options using the CMake option command instead of directly setting the cache (since option will allow IDEs to see that they are options that the user can change/modify).

Also change the CMake variable that the unit tests are gated on to be unique to this project.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 175

Totals Coverage Status
Change from base Build 170: 0.0%
Covered Lines: 87
Relevant Lines: 87
💛 - Coveralls
coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1292497484

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Totals Coverage Status
Change from base Build 1291160185: 0.0%
Covered Lines: 87
Relevant Lines: 87
💛 - Coveralls
imciner2 commented 3 years ago

@bstellato I have merged the recent changes into this PR so it is now ready for review.