mbhatt1
commented
4 years ago Any movement on this?
Closed avcarrillo closed 1 year ago
mbhatt1
commented
4 years ago Any movement on this?
zwass
commented
4 years ago Are you running into an issue due to this? The race looks to be deep into the Thrift code.
mbhatt1
commented
4 years ago Hit it once before.
0xpaulbenoit
commented
4 years ago I have experienced osquery extension issues due to this as well
avcarrillo
commented
4 years ago @zwass , Yes, it causes a memory leak which grows over time. I have to continually restart the service to keep it from growing out of control
avcarrillo
commented
4 years ago Same as @zwass, It causes a memory leak, and I have to continually restart the service. The more queries I execute against my osquery-go extension, the quicker the leak grows
lucasmrod
commented
1 year ago AFAICS this was fixed by https://github.com/osquery/osquery-go/pull/108
git checkout d2e851b3991b0728fdacce7e0f3a2d51a7f524cb # this is the commit before #108
$ cd examples/table
$ go build -race -o main main.go
$ sudo ./main --socket /var/osquery/osquery.em
➜ table git:(d2e851b) ✗ sudo ./main --socket /var/osquery/osquery.em
==================
WARNING: DATA RACE
Read at 0x00c000017050 by goroutine 9:
github.com/apache/thrift/lib/go/thrift.(*TStandardClient).Call()
/Users/luk/gopath/pkg/mod/github.com/apache/thrift@v0.16.0/lib/go/thrift/client.go:89 +0x93
github.com/osquery/osquery-go/gen/osquery.(*ExtensionClient).Ping()
/Users/luk/fleetdm/git/osquery-go/gen/osquery/osquery.go:1239 +0xe1
github.com/osquery/osquery-go/gen/osquery.(*ExtensionManagerClient).Ping()
<autogenerated>:1 +0x67
github.com/osquery/osquery-go.(*ExtensionManagerClient).Ping()
/Users/luk/fleetdm/git/osquery-go/client.go:47 +0x6b
github.com/osquery/osquery-go.(*ExtensionManagerServer).Run.func2()
/Users/luk/fleetdm/git/osquery-go/server.go:256 +0x7eNow when trying in master as of today there's no race condition:
git log -n 1
dbeefc07d76e3edaf614647a20cc588c1b4f47e4
go build -race -o main main.go
sudo ./main --socket /var/osquery/osquery.em
<no output and table plugin example_table works as expected>@directionless @RebeccaMahany
RebeccaMahany
commented
1 year ago @lucasmrod thanks for looking into this -- I agree that this looks like it was fixed by locking client access. Probably good to close this out?
While trying to track down a memory leak with my extension, I found there is a race condition.
When running the example and using the -race flag with go run, there is a race condition
C:\Users..\go\src\test\osquery>go run -race main.go \.\pipe\osquery.em
WARNING: DATA RACE Read at 0x00c0000c6960 by goroutine 10: git.apache.org/thrift.git/lib/go/thrift.(TStandardClient).Call() C:/Users/../go/src/git.apache.org/thrift.git/lib/go/thrift/client.go:82 +0x59 github.com/kolide/osquery-go/gen/osquery.(ExtensionClient).Ping() C:/Users/../go/src/github.com/kolide/osquery-go/gen/osquery/osquery.go:1022 +0xfd github.com/kolide/osquery-go/gen/osquery.(*ExtensionManagerClient).Ping()