osquery / osquery-go

Go bindings for osquery
MIT License
388 stars 79 forks source link

Close the client pipe on shutdown #73

Closed sroache closed 1 year ago

sroache commented 5 years ago

When shutting down the extension the named pipe that is created by the extension is closed however the "client" (the handle to the pipe created by osquery - used for pings) is not closed. This leads to osquery not closing correctly when the extension is still connected.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

sroache commented 4 years ago

@zwass Sorry this took so long. The CLA has been signed now. Is there a way to re-trigger the build?

zwass commented 4 years ago

@sroache you can push new changes to the branch to trigger a rebuild, or we will have to ask @directionless to trigger it (I no longer have write access to this repository).

sroache commented 4 years ago

@directionless Both this PR and develop appear to be failing for the same reason. Do you know anything about this?