Fix error in Makefile when gen directory exists

osquery / osquery-go

Go bindings for osquery

MIT License

386 stars 78 forks source link

Fix error in Makefile when gen directory exists #74

Closed zwass closed 4 years ago

directionless commented 5 years ago

That test failure was weird. I think we sere it a lot.

From what I can see:

test depends on gen
gen runs thrift using osquery.thrift to generate ./gen
If osquery.thrift is new, this rule will trigger

I'm not sure why circleci seems to, only sometimes, want to trigger that

directionless commented 5 years ago

Possibly, we should just remove pre-requisite on osquery.thrift here. Then make won't take it into account, and would only trigger when gen wasn't present.

directionless commented 4 years ago

Got fixed in #83