osquery / tools

Tools for packaging and signing osquery
2 stars 5 forks source link

Fix: Only get commits between the "last" and "new" commits #5

Closed Smjert closed 3 months ago

Smjert commented 1 year ago

Currently the range taken is from the "last" commit timestamp and "master", but we don't want commits that are after the release we are creating the changelog for. Using the "new" tag instead of the hardcoded string "master" achieves this.

Smjert commented 1 year ago

By the way it seems that we have to update the golangci-lint tooling, but then there are some checks that are deprecated and some that have moved (like in govet). I'm not too familiar with golang tooling; I saw that in .yml file you can configure which linters to use and for each linter you can pass options to it. I stopped when I was trying to understand if govet was using a certain specific check by default or not and what I would've to do to add it on top of the rest of the default checks.

I might look into this during the holidays, but I guess it might be quicker if someone more used to golang tooling does this ^^'.

directionless commented 3 months ago

I think I did this in a different PR