search

osquery / tools

Tools for packaging and signing osquery
2 stars 5 forks source link

Incorrect range of commits picked up #8

Open Smjert opened 5 months ago

Smjert commented 5 months ago

I haven't investigated too much but see this issue: https://github.com/osquery/osquery/issues/8346

I have cloned the latest version and run it with go run ./cmd/release-notes --changelog CHANGELOG.md --last 5.12.1 --new 5.12.2 and indeed it puts in commits that should not be there (they are on master).

Between 5.12.1 and 5.12.2 only 2 commits exists: https://github.com/osquery/osquery/compare/5.12.1...5.12.2

Smjert commented 5 months ago

I have rerun the tool using my branch with the fix I did in my PR: https://github.com/osquery/tools/pull/5, and even with that it doesn't work as it should. It's picking up less commits:

[...]
### FIXME: Please Categorize

- CI: Fix macOS python dependencies install step (#8308) (MISSING PR for commit 2ad0ea9e15751f948dfbe9af04753bcc4290dfd3) ([#0](https://github.com/osquery/osquery/pull/0))
- Downgrade sqlite to 3.42 to prevent a regression with required columns ([#8295](https://github.com/osquery/osquery/pull/8295))
[...]

but still the incorrect ones; furthermore here I'm pointing the tool to a changelog file which is not in the osquery repo folder, but if I point to the one in the repo folder, somehow the "Downgrade sqlite to..." commit is not picked up. The fact that's not picked up is correct since that was already in 5.12.1, but I don't get why the CHANGELOG.md position should change the result.

Smjert commented 5 months ago

Looking at the query done seems like master is hardcoded: https://github.com/osquery/tools/blob/00935e7d0ea8e6605fca09454966f5ef2c070522/cmd/release-notes/fetch.go#L13

Not sure how to change this, but it should instead detect where each tag is located if the setting the branch name is needed, because the diff here is between two branches that are not master.