osrec / currencyFormatter.js

A super simple currency formatting library
MIT License
635 stars 61 forks source link

Behaviour for '#' and '0' #37

Open manojchandrashekar opened 5 years ago

manojchandrashekar commented 5 years ago

The patterns do not behave as expected? When using #, the number should not substitute a 0 in the price, unless it is used with #0

This is correct:

OSREC.CurrencyFormatter.format(0.45, {pattern: "#,##0.## !"})

>> "0.45 $"

Incorrect (?):

OSREC.CurrencyFormatter.format(0.45, {pattern: "#,##.## !"})

>> "0.45 $"

Expected:

>> ".45 $"

Incorrect (?):

OSREC.CurrencyFormatter.format(120, {pattern: "#,##0.##00 !"})

>> "120.0000 $"

Expected:

>> "120.00 $"

Incorrect (?):

OSREC.CurrencyFormatter.format(120, {pattern: "#,##0.## !"})

>> "120.00 $"

Expected:

>> "120 $"

Is this not what was planned for the patterns?