search

osrec / currencyFormatter.js

A super simple currency formatting library
MIT License
635 stars 61 forks source link

Consider using unicode currency symbols #6

Closed richardvenneman closed 7 years ago

richardvenneman commented 7 years ago

Hi,

Thanks for the great lib.

What's the reason HTML entities are being used for currency symbols? When rendering the CurrencyFormatter output in React/JSX this requires dangerouslySetInnerHTML, which is troublesome. Would you consider replacing the HTML entities with unicode characters? If so, I can make a pull request.

osrec commented 7 years ago

Hi Richard, yes absolutely :)

osrec commented 7 years ago

Thanks for the pull request Richard - this has been merged :)

richardvenneman commented 7 years ago

No problem, thanks for the fast merge!

It would be super nice if you could also bump and release a new version on NPM :)

osrec commented 7 years ago

Yes absolutely! We'll be adding a few more bug fixes in a couple of weeks and will release all together :)