search

osrf / cloudsim-widgets

Other
0 stars 1 forks source link

machinekillbutton lies about killing machines #15

Open osrf-migration opened 8 years ago

osrf-migration commented 8 years ago

Original report (archived issue) by Hugo Boyer (Bitbucket: hugomatic, GitHub: hugomatic).

The code assumes success.

#!python

 onKilled: function(e) {
        this.fire('notification',
            {msg: "Machine has been killed.", type: "msg"})
      },

e.detail.success can be false, with a message in: e.detail.msg

Also, the button appears when it shouldn't (after a revoke)

osrf-migration commented 8 years ago

Original comment by Hugo Boyer (Bitbucket: hugomatic, GitHub: hugomatic).

After giving it more thoughs, I'm starting to wonder if the problem is not with the server. The message reads "Failed to kill simulator.", but it is actually due to a lack of permission. If the status of the request had been 401 instead of 200, the error would have been reported correctly.

osrf-migration commented 7 years ago

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).

I wonder if this is still an issue since we started using gz-resources to kill machines. Not sure how to reproduce the original problem...