Open osrf-migration opened 8 years ago
Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).
Menu highlighting fixed on pull request #24
Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).
Pull request #74 fixes the problems with refresh and directly typing a route.
The issue with /
inside routes is not fixed yet.
Original report (archived issue) by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).
There are a few problems with the routing performed at routing.html:
Routes currently can't have
/
inside them, we need to rethink this line:page.base(app.baseUrl.replace(/\/$/, ''))
Routes don't stick on refresh. For example, if you're at
https://localhost:5000/src-kiosk
and refresh the browser, you are sent to the dashboard. The same happens if you copy that url into another browser.When we go to a new route without going through the menu, the wrong menu item is highlighted.