search

osrf / docker_images

A repository to hold definitions of docker images maintained by OSRF
Apache License 2.0
570 stars 170 forks source link

Cannot locate rosdep definition in ros:nightly build #317

Closed ruffsl closed 5 years ago

ruffsl commented 5 years ago

Looks like rosdep cannot locate rosdep definition for a number of packages, which is blocking the build for all nightly tags. This seems to have started occurring about 3 days ago:

``` ... Reading package lists... ERROR: the following packages/stacks could not have their rosdep keys resolved to system dependencies: rqt_reconfigure: Cannot locate rosdep definition for [ament_flake8] ros1_bridge: Cannot locate rosdep definition for [ros2run] ament_cmake_core: Cannot locate rosdep definition for [ament_package] examples_rclpy_minimal_subscriber: Cannot locate rosdep definition for [ament_flake8] rqt_gui: Cannot locate rosdep definition for [ament_index_python] ament_lint_cmake: Cannot locate rosdep definition for [ament_flake8] examples_rclpy_minimal_action_client: Cannot locate rosdep definition for [ament_flake8] lifecycle: Cannot locate rosdep definition for [ros2run] rosidl_generator_py: Cannot locate rosdep definition for [ament_index_python] ament_cmake_ros: Cannot locate rosdep definition for [domain_coordinator] examples_rclpy_minimal_action_server: Cannot locate rosdep definition for [ament_flake8] demo_nodes_cpp_native: Cannot locate rosdep definition for [launch_testing_ros] test_cli_remapping: Cannot locate rosdep definition for [launch_testing] ros_workspace: Cannot locate rosdep definition for [ament_package] launch: Cannot locate rosdep definition for [ament_flake8] rclpy: Cannot locate rosdep definition for [ament_index_python] image_tools: Cannot locate rosdep definition for [launch_testing_ros] ament_pep257: Cannot locate rosdep definition for [ament_flake8] test_ros2cli: Cannot locate rosdep definition for [ros2msg] ament_clang_tidy: Cannot locate rosdep definition for [ament_flake8] intra_process_demo: Cannot locate rosdep definition for [launch_testing] ament_pclint: Cannot locate rosdep definition for [ament_flake8] demo_nodes_cpp: Cannot locate rosdep definition for [launch_testing_ros] ament_xmllint: Cannot locate rosdep definition for [ament_flake8] rqt_py_console: Cannot locate rosdep definition for [ament_index_python] qt_gui: Cannot locate rosdep definition for [ament_index_python] rosbag2_tests: Cannot locate rosdep definition for [ros2bag] ros_testing: Cannot locate rosdep definition for [ros2test] rqt_console: Cannot locate rosdep definition for [ament_index_python] composition: Cannot locate rosdep definition for [launch_testing_ros] launch_ros: Cannot locate rosdep definition for [ament_flake8] ament_cpplint: Cannot locate rosdep definition for [ament_flake8] dummy_robot_bringup: Cannot locate rosdep definition for [ros2run] ament_clang_format: Cannot locate rosdep definition for [ament_flake8] examples_rclpy_minimal_client: Cannot locate rosdep definition for [ament_flake8] rcl: Cannot locate rosdep definition for [launch_testing] rcl_logging_log4cxx: Cannot locate rosdep definition for [launch_testing] demo_nodes_py: Cannot locate rosdep definition for [ament_flake8] qt_gui_app: Cannot locate rosdep definition for [ament_index_python] test_launch_testing: Cannot locate rosdep definition for [launch_testing] quality_of_service_demo_cpp: Cannot locate rosdep definition for [launch_testing] test_communication: Cannot locate rosdep definition for [launch_testing] examples_rclpy_minimal_publisher: Cannot locate rosdep definition for [ament_flake8] test_security: Cannot locate rosdep definition for [sros2] rcl_logging_noop: Cannot locate rosdep definition for [launch_testing] rqt_graph: Cannot locate rosdep definition for [ament_index_python] qt_gui_py_common: Cannot locate rosdep definition for [ament_index_python] pendulum_control: Cannot locate rosdep definition for [ros2run] topic_monitor: Cannot locate rosdep definition for [ament_flake8] test_rclcpp: Cannot locate rosdep definition for [launch_testing_ros] examples_rclpy_minimal_service: Cannot locate rosdep definition for [ament_flake8] logging_demo: Cannot locate rosdep definition for [launch_testing_ros] rclcpp_components: Cannot locate rosdep definition for [launch_testing] ament_mypy: Cannot locate rosdep definition for [ament_flake8] ament_copyright: Cannot locate rosdep definition for [ament_flake8] sros2_cmake: Cannot locate rosdep definition for [ros2cli] quality_of_service_demo_py: Cannot locate rosdep definition for [ament_flake8] rcutils: Cannot locate rosdep definition for [launch_testing] examples_rclpy_executors: Cannot locate rosdep definition for [ament_flake8] Removing intermediate container 50b423f71263 The command '/bin/sh -c . /opt/ros/$ROS_DISTRO/setup.sh && apt-get update && rosdep install -y --from-paths /opt/ros/$ROS_DISTRO/share --ignore-src --skip-keys " libopensplice69 rti-connext-dds-5.3.1" && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 1 ```
nuclearsandwich commented 5 years ago

Did the switch from dashing to eloquent happen three days ago? Eloquent is still be being bootstrapped and the rosdistro source entries for these packages aren't present.

ruffsl commented 5 years ago

The switch was made here 18 days ago in the docketfile: https://github.com/osrf/docker_images/pull/311

The images where building then, but the index has been disabled before that: https://github.com/osrf/docker_images/pull/307

nuclearsandwich commented 5 years ago

Ah, brainwave. This is related to https://github.com/colcon/colcon-ros/pull/74

If I am reading https://github.com/osrf/docker_images/pull/307#issuecomment-520095593 we don't want the eloquent source entries when building the nightlies.

colcon was covering for these packages previously and now it isn't. I'm pretty sure that all of them should be fixed on latest. At least we fixed what we needed to resolve other CI failures. @mjcarroll we talked about this offline as something for the Eloquent alpha but I don't think anything we're doing there affects this after all.

ruffsl commented 5 years ago

I'm pretty sure that all of them should be fixed on latest.

Is there any action we should take here to resolve this, or do we just need to wait for fixes on latest to propicage to the nightly build?

nuclearsandwich commented 5 years ago

Is there any action we should take here to resolve this, or do we just need to wait for fixes on latest to propicage to the nightly build?

The nightlies should be on latest. @ruffsl can you drop me a breadcrumb for where I can see the latest image build log. It's possible that either some fixes were incomplete or there are more to be performed which aren't caught by our CI for some reason.

ruffsl commented 5 years ago

The recent build logs can be viewed from the manage console in docker huh for the repo. You'll need to login to see the log output: https://cloud.docker.com/u/osrf/repository/docker/osrf/ros2/builds

ruffsl commented 5 years ago

Any developments? Todays build log still reports the same errors as original detailed above.

ruffsl commented 5 years ago

This is the ament index currently installed from the nightly fat archive, looks like a lot is still missing:

$ ls /opt/ros/eloquent/share/ament_index/resource_index
package_run_dependencies  qt_gui__pluginlib__plugin  rmw_typesupport      rosbag2__pluginlib__plugin          rosidl_interfaces        rosidl_typesupport_cpp
packages                  rclcpp_components          rmw_typesupport_c    rosbag2_storage__pluginlib__plugin  rosidl_runtime_packages  rviz_common__pluginlib__plugin
parent_prefix_path        rmw_output_prefixes        rmw_typesupport_cpp  rosidl_generator_packages           rosidl_typesupport_c
ruffsl commented 5 years ago

The nightlies should be on latest.

@nuclearsandwich , is this still the case?

ruffsl commented 5 years ago

@tfoote or @sloretz , are any other users the nightly fat archives having issues with installing due to the missing entries in resource_index or missing package.xml files? We can't be the only folks still being affected by the colcon changes upstream from two weeks ago?

ruffsl commented 5 years ago

As of writing, here are the list of packages that are still not registered in the ament_index: (cc @dirk-thomas )

``` diff --- +++ @@ -3,6 +3,8 @@ action_tutorials_interfaces action_tutorials_py actionlib_msgs +ament_clang_format +ament_clang_tidy ament_cmake ament_cmake_auto ament_cmake_clang_format @@ -36,11 +38,28 @@ ament_cmake_test ament_cmake_uncrustify ament_cmake_xmllint +ament_copyright +ament_cppcheck +ament_cpplint +ament_flake8 +ament_index ament_index_cpp +ament_index_python +ament_lint ament_lint_auto +ament_lint_cmake ament_lint_common +ament_mypy +ament_package +ament_pclint +ament_pep257 +ament_pep8 +ament_pyflakes +ament_uncrustify +ament_xmllint builtin_interfaces class_loader +colcon-core common_interfaces composition composition_interfaces @@ -50,6 +69,7 @@ demo_nodes_cpp_native demo_nodes_py diagnostic_msgs +doc domain_coordinator dummy_map_server dummy_robot_bringup @@ -71,8 +91,14 @@ examples_rclpy_minimal_publisher examples_rclpy_minimal_service examples_rclpy_minimal_subscriber +fastcdr +fastrtps fastrtps_cmake_module +foonathan_memory +foonathan_memory_vendor geometry_msgs +gmock_vendor +gtest_vendor image_tools interactive_markers intra_process_demo @@ -83,6 +109,8 @@ launch_testing launch_testing_ament_cmake launch_testing_ros +launch_xml +launch_yaml libcurl_vendor libyaml_vendor lifecycle @@ -93,9 +121,13 @@ move_base_msgs nav_msgs opensplice_cmake_module +orocos_kdl +osrf_pycommon +osrf_testing_tools_cpp pendulum_control pendulum_msgs pluginlib +poco_vendor python_cmake_module python_qt_binding qt_dotgraph @@ -132,7 +164,24 @@ rmw_opensplice_cpp robot_state_publisher ros1_bridge +ros2action +ros2bag ros2cli +ros2component +ros2doctor +ros2interface +ros2launch +ros2lifecycle +ros2msg +ros2multicast +ros2node +ros2param +ros2pkg +ros2run +ros2service +ros2srv +ros2test +ros2topic ros_environment ros_testing ros_workspace @@ -153,6 +202,7 @@ rosidl_generator_dds_idl rosidl_generator_py rosidl_parser +rosidl_runtime_py rosidl_typesupport_c rosidl_typesupport_connext_c rosidl_typesupport_connext_cpp @@ -192,6 +242,8 @@ sensor_msgs shape_msgs shared_queues_vendor +sqlite3_vendor +sros2 sros2_cmake std_msgs std_srvs @@ -200,8 +252,10 @@ test_cli_remapping test_communication test_interface_files +test_launch_ros test_launch_testing test_msgs +test_osrf_testing_tools_cpp test_quality_of_service test_rclcpp test_ros2cli @@ -213,6 +267,9 @@ tf2_msgs tf2_ros tf2_sensor_msgs +tinydir_vendor +tinyxml2_vendor +tinyxml_vendor tlsf tlsf_cpp topic_monitor @@ -220,5 +277,7 @@ uncrustify_vendor unique_identifier_msgs urdf +urdfdom +urdfdom_headers visualization_msgs yaml_cpp_vendor ```
``` $ ls -1 share/ament_index/resource_index/packages/ action_msgs action_tutorials_cpp action_tutorials_interfaces action_tutorials_py actionlib_msgs ament_cmake ament_cmake_auto ament_cmake_clang_format ament_cmake_clang_tidy ament_cmake_copyright ament_cmake_core ament_cmake_cppcheck ament_cmake_cpplint ament_cmake_export_definitions ament_cmake_export_dependencies ament_cmake_export_include_directories ament_cmake_export_interfaces ament_cmake_export_libraries ament_cmake_export_link_flags ament_cmake_flake8 ament_cmake_gmock ament_cmake_gtest ament_cmake_include_directories ament_cmake_libraries ament_cmake_lint_cmake ament_cmake_mypy ament_cmake_nose ament_cmake_pclint ament_cmake_pep257 ament_cmake_pep8 ament_cmake_pyflakes ament_cmake_pytest ament_cmake_python ament_cmake_ros ament_cmake_target_dependencies ament_cmake_test ament_cmake_uncrustify ament_cmake_xmllint ament_index_cpp ament_lint_auto ament_lint_common builtin_interfaces class_loader common_interfaces composition composition_interfaces connext_cmake_module console_bridge_vendor demo_nodes_cpp demo_nodes_cpp_native demo_nodes_py diagnostic_msgs domain_coordinator dummy_map_server dummy_robot_bringup dummy_sensors eigen3_cmake_module example_interfaces examples_rclcpp_minimal_action_client examples_rclcpp_minimal_action_server examples_rclcpp_minimal_client examples_rclcpp_minimal_composition examples_rclcpp_minimal_publisher examples_rclcpp_minimal_service examples_rclcpp_minimal_subscriber examples_rclcpp_minimal_timer examples_rclpy_executors examples_rclpy_minimal_action_client examples_rclpy_minimal_action_server examples_rclpy_minimal_client examples_rclpy_minimal_publisher examples_rclpy_minimal_service examples_rclpy_minimal_subscriber fastrtps_cmake_module geometry_msgs image_tools interactive_markers intra_process_demo kdl_parser laser_geometry launch launch_ros launch_testing launch_testing_ament_cmake launch_testing_ros libcurl_vendor libyaml_vendor lifecycle lifecycle_msgs logging_demo map_msgs message_filters move_base_msgs nav_msgs opensplice_cmake_module pendulum_control pendulum_msgs pluginlib python_cmake_module python_qt_binding qt_dotgraph qt_gui qt_gui_app qt_gui_core qt_gui_cpp qt_gui_py_common quality_of_service_demo_cpp quality_of_service_demo_py rcl rcl_action rcl_interfaces rcl_lifecycle rcl_logging_log4cxx rcl_logging_noop rcl_yaml_param_parser rclcpp rclcpp_action rclcpp_components rclcpp_lifecycle rclpy rcpputils rcutils resource_retriever rmw rmw_connext_cpp rmw_connext_shared_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_implementation rmw_implementation_cmake rmw_opensplice_cpp robot_state_publisher ros1_bridge ros2cli ros_environment ros_testing ros_workspace rosbag2 rosbag2_converter_default_plugins rosbag2_storage rosbag2_storage_default_plugins rosbag2_test_common rosbag2_tests rosbag2_transport rosgraph_msgs rosidl_adapter rosidl_cmake rosidl_default_generators rosidl_default_runtime rosidl_generator_c rosidl_generator_cpp rosidl_generator_dds_idl rosidl_generator_py rosidl_parser rosidl_typesupport_c rosidl_typesupport_connext_c rosidl_typesupport_connext_cpp rosidl_typesupport_cpp rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp rosidl_typesupport_interface rosidl_typesupport_introspection_c rosidl_typesupport_introspection_cpp rosidl_typesupport_opensplice_c rosidl_typesupport_opensplice_cpp rqt rqt_console rqt_graph rqt_gui rqt_gui_cpp rqt_gui_py rqt_msg rqt_plot rqt_publisher rqt_py_common rqt_py_console rqt_reconfigure rqt_service_caller rqt_shell rqt_srv rqt_top rttest rviz2 rviz_assimp_vendor rviz_common rviz_default_plugins rviz_ogre_vendor rviz_rendering rviz_rendering_tests rviz_visual_testing_framework sensor_msgs shape_msgs shared_queues_vendor sros2_cmake std_msgs std_srvs stereo_msgs test_cli test_cli_remapping test_communication test_interface_files test_launch_testing test_msgs test_quality_of_service test_rclcpp test_ros2cli test_security tf2 tf2_eigen tf2_geometry_msgs tf2_kdl tf2_msgs tf2_ros tf2_sensor_msgs tlsf tlsf_cpp topic_monitor trajectory_msgs uncrustify_vendor unique_identifier_msgs urdf visualization_msgs yaml_cpp_vendor ``` ``` $ ls -1 share/ action_msgs action_tutorials_cpp action_tutorials_interfaces action_tutorials_py actionlib_msgs ament_clang_format ament_clang_tidy ament_cmake ament_cmake_auto ament_cmake_clang_format ament_cmake_clang_tidy ament_cmake_copyright ament_cmake_core ament_cmake_cppcheck ament_cmake_cpplint ament_cmake_export_definitions ament_cmake_export_dependencies ament_cmake_export_include_directories ament_cmake_export_interfaces ament_cmake_export_libraries ament_cmake_export_link_flags ament_cmake_flake8 ament_cmake_gmock ament_cmake_gtest ament_cmake_include_directories ament_cmake_libraries ament_cmake_lint_cmake ament_cmake_mypy ament_cmake_nose ament_cmake_pclint ament_cmake_pep257 ament_cmake_pep8 ament_cmake_pyflakes ament_cmake_pytest ament_cmake_python ament_cmake_ros ament_cmake_target_dependencies ament_cmake_test ament_cmake_uncrustify ament_cmake_xmllint ament_copyright ament_cppcheck ament_cpplint ament_flake8 ament_index ament_index_cpp ament_index_python ament_lint ament_lint_auto ament_lint_cmake ament_lint_common ament_mypy ament_package ament_pclint ament_pep257 ament_pep8 ament_pyflakes ament_uncrustify ament_xmllint builtin_interfaces class_loader colcon-core common_interfaces composition composition_interfaces connext_cmake_module console_bridge_vendor demo_nodes_cpp demo_nodes_cpp_native demo_nodes_py diagnostic_msgs doc domain_coordinator dummy_map_server dummy_robot_bringup dummy_sensors eigen3_cmake_module example_interfaces examples_rclcpp_minimal_action_client examples_rclcpp_minimal_action_server examples_rclcpp_minimal_client examples_rclcpp_minimal_composition examples_rclcpp_minimal_publisher examples_rclcpp_minimal_service examples_rclcpp_minimal_subscriber examples_rclcpp_minimal_timer examples_rclpy_executors examples_rclpy_minimal_action_client examples_rclpy_minimal_action_server examples_rclpy_minimal_client examples_rclpy_minimal_publisher examples_rclpy_minimal_service examples_rclpy_minimal_subscriber fastcdr fastrtps fastrtps_cmake_module foonathan_memory foonathan_memory_vendor geometry_msgs gmock_vendor gtest_vendor image_tools interactive_markers intra_process_demo kdl_parser laser_geometry launch launch_ros launch_testing launch_testing_ament_cmake launch_testing_ros launch_xml launch_yaml libcurl_vendor libyaml_vendor lifecycle lifecycle_msgs logging_demo map_msgs message_filters move_base_msgs nav_msgs opensplice_cmake_module orocos_kdl osrf_pycommon osrf_testing_tools_cpp pendulum_control pendulum_msgs pluginlib poco_vendor python_cmake_module python_qt_binding qt_dotgraph qt_gui qt_gui_app qt_gui_core qt_gui_cpp qt_gui_py_common quality_of_service_demo_cpp quality_of_service_demo_py rcl rcl_action rcl_interfaces rcl_lifecycle rcl_logging_log4cxx rcl_logging_noop rcl_yaml_param_parser rclcpp rclcpp_action rclcpp_components rclcpp_lifecycle rclpy rcpputils rcutils resource_retriever rmw rmw_connext_cpp rmw_connext_shared_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_implementation rmw_implementation_cmake rmw_opensplice_cpp robot_state_publisher ros1_bridge ros2action ros2bag ros2cli ros2component ros2doctor ros2interface ros2launch ros2lifecycle ros2msg ros2multicast ros2node ros2param ros2pkg ros2run ros2service ros2srv ros2test ros2topic ros_environment ros_testing ros_workspace rosbag2 rosbag2_converter_default_plugins rosbag2_storage rosbag2_storage_default_plugins rosbag2_test_common rosbag2_tests rosbag2_transport rosgraph_msgs rosidl_adapter rosidl_cmake rosidl_default_generators rosidl_default_runtime rosidl_generator_c rosidl_generator_cpp rosidl_generator_dds_idl rosidl_generator_py rosidl_parser rosidl_runtime_py rosidl_typesupport_c rosidl_typesupport_connext_c rosidl_typesupport_connext_cpp rosidl_typesupport_cpp rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp rosidl_typesupport_interface rosidl_typesupport_introspection_c rosidl_typesupport_introspection_cpp rosidl_typesupport_opensplice_c rosidl_typesupport_opensplice_cpp rqt rqt_console rqt_graph rqt_gui rqt_gui_cpp rqt_gui_py rqt_msg rqt_plot rqt_publisher rqt_py_common rqt_py_console rqt_reconfigure rqt_service_caller rqt_shell rqt_srv rqt_top rttest rviz2 rviz_assimp_vendor rviz_common rviz_default_plugins rviz_ogre_vendor rviz_rendering rviz_rendering_tests rviz_visual_testing_framework sensor_msgs shape_msgs shared_queues_vendor sqlite3_vendor sros2 sros2_cmake std_msgs std_srvs stereo_msgs test_cli test_cli_remapping test_communication test_interface_files test_launch_ros test_launch_testing test_msgs test_osrf_testing_tools_cpp test_quality_of_service test_rclcpp test_ros2cli test_security tf2 tf2_eigen tf2_geometry_msgs tf2_kdl tf2_msgs tf2_ros tf2_sensor_msgs tinydir_vendor tinyxml2_vendor tinyxml_vendor tlsf tlsf_cpp topic_monitor trajectory_msgs uncrustify_vendor unique_identifier_msgs urdf urdfdom urdfdom_headers visualization_msgs yaml_cpp_vendor ```
dirk-thomas commented 5 years ago

You can also use this draft PR to determine missing installations: colcon/colcon-ros#79. There are certainly still items missing.

@ruffsl I just don't understand your (diff) list from the previous post. Some entries don't seem to make any sense.

ruffsl commented 5 years ago

@ruffsl I just don't understand your (diff) list from the previous post. Some entries don't seem to make any sense.

I was just diff'ing the output of ls from the share folder vs that of resource_index/packages.

Alternately, here is the diff between packages in the index, vs packages that include a package.xml.

``` diff --- +++ @@ -3,8 +3,6 @@ action_tutorials_interfaces action_tutorials_py actionlib_msgs -ament_clang_format -ament_clang_tidy ament_cmake ament_cmake_auto ament_cmake_clang_format @@ -38,22 +36,9 @@ ament_cmake_test ament_cmake_uncrustify ament_cmake_xmllint -ament_copyright -ament_cppcheck -ament_cpplint -ament_flake8 ament_index_cpp -ament_lint ament_lint_auto -ament_lint_cmake ament_lint_common -ament_mypy -ament_pclint -ament_pep257 -ament_pep8 -ament_pyflakes -ament_uncrustify -ament_xmllint builtin_interfaces class_loader common_interfaces @@ -87,10 +72,7 @@ examples_rclpy_minimal_service examples_rclpy_minimal_subscriber fastrtps_cmake_module -foonathan_memory_vendor geometry_msgs -gmock_vendor -gtest_vendor image_tools interactive_markers intra_process_demo @@ -98,7 +80,9 @@ laser_geometry launch launch_ros +launch_testing launch_testing_ament_cmake +launch_testing_ros libcurl_vendor libyaml_vendor lifecycle @@ -109,12 +93,9 @@ move_base_msgs nav_msgs opensplice_cmake_module -orocos_kdl -osrf_testing_tools_cpp pendulum_control pendulum_msgs pluginlib -poco_vendor python_cmake_module python_qt_binding qt_dotgraph @@ -151,6 +132,7 @@ rmw_opensplice_cpp robot_state_publisher ros1_bridge +ros2cli ros_environment ros_testing ros_workspace @@ -210,7 +192,6 @@ sensor_msgs shape_msgs shared_queues_vendor -sqlite3_vendor sros2_cmake std_msgs std_srvs @@ -232,9 +213,6 @@ tf2_msgs tf2_ros tf2_sensor_msgs -tinydir_vendor -tinyxml2_vendor -tinyxml_vendor tlsf tlsf_cpp topic_monitor @@ -242,6 +220,5 @@ uncrustify_vendor unique_identifier_msgs urdf -urdfdom visualization_msgs yaml_cpp_vendor ```
``` $ find . -name "package.xml" | sed 's!./!!' | sed -r 's/.{12}$//' | sort action_msgs action_tutorials_cpp action_tutorials_interfaces action_tutorials_py actionlib_msgs ament_clang_format ament_clang_tidy ament_cmake ament_cmake_auto ament_cmake_clang_format ament_cmake_clang_tidy ament_cmake_copyright ament_cmake_core ament_cmake_cppcheck ament_cmake_cpplint ament_cmake_export_definitions ament_cmake_export_dependencies ament_cmake_export_include_directories ament_cmake_export_interfaces ament_cmake_export_libraries ament_cmake_export_link_flags ament_cmake_flake8 ament_cmake_gmock ament_cmake_gtest ament_cmake_include_directories ament_cmake_libraries ament_cmake_lint_cmake ament_cmake_mypy ament_cmake_nose ament_cmake_pclint ament_cmake_pep257 ament_cmake_pep8 ament_cmake_pyflakes ament_cmake_pytest ament_cmake_python ament_cmake_ros ament_cmake_target_dependencies ament_cmake_test ament_cmake_uncrustify ament_cmake_xmllint ament_copyright ament_cppcheck ament_cpplint ament_flake8 ament_index_cpp ament_lint ament_lint_auto ament_lint_cmake ament_lint_common ament_mypy ament_pclint ament_pep257 ament_pep8 ament_pyflakes ament_uncrustify ament_xmllint builtin_interfaces class_loader common_interfaces composition composition_interfaces connext_cmake_module console_bridge_vendor demo_nodes_cpp demo_nodes_cpp_native demo_nodes_py diagnostic_msgs domain_coordinator dummy_map_server dummy_robot_bringup dummy_sensors eigen3_cmake_module example_interfaces examples_rclcpp_minimal_action_client examples_rclcpp_minimal_action_server examples_rclcpp_minimal_client examples_rclcpp_minimal_composition examples_rclcpp_minimal_publisher examples_rclcpp_minimal_service examples_rclcpp_minimal_subscriber examples_rclcpp_minimal_timer examples_rclpy_executors examples_rclpy_minimal_action_client examples_rclpy_minimal_action_server examples_rclpy_minimal_client examples_rclpy_minimal_publisher examples_rclpy_minimal_service examples_rclpy_minimal_subscriber fastrtps_cmake_module foonathan_memory_vendor geometry_msgs gmock_vendor gtest_vendor image_tools interactive_markers intra_process_demo kdl_parser laser_geometry launch launch_ros launch_testing_ament_cmake libcurl_vendor libyaml_vendor lifecycle lifecycle_msgs logging_demo map_msgs message_filters move_base_msgs nav_msgs opensplice_cmake_module orocos_kdl osrf_testing_tools_cpp pendulum_control pendulum_msgs pluginlib poco_vendor python_cmake_module python_qt_binding qt_dotgraph qt_gui qt_gui_app qt_gui_core qt_gui_cpp qt_gui_py_common quality_of_service_demo_cpp quality_of_service_demo_py rcl rcl_action rcl_interfaces rcl_lifecycle rcl_logging_log4cxx rcl_logging_noop rcl_yaml_param_parser rclcpp rclcpp_action rclcpp_components rclcpp_lifecycle rclpy rcpputils rcutils resource_retriever rmw rmw_connext_cpp rmw_connext_shared_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_implementation rmw_implementation_cmake rmw_opensplice_cpp robot_state_publisher ros1_bridge ros_environment ros_testing ros_workspace rosbag2 rosbag2_converter_default_plugins rosbag2_storage rosbag2_storage_default_plugins rosbag2_test_common rosbag2_tests rosbag2_transport rosgraph_msgs rosidl_adapter rosidl_cmake rosidl_default_generators rosidl_default_runtime rosidl_generator_c rosidl_generator_cpp rosidl_generator_dds_idl rosidl_generator_py rosidl_parser rosidl_typesupport_c rosidl_typesupport_connext_c rosidl_typesupport_connext_cpp rosidl_typesupport_cpp rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp rosidl_typesupport_interface rosidl_typesupport_introspection_c rosidl_typesupport_introspection_cpp rosidl_typesupport_opensplice_c rosidl_typesupport_opensplice_cpp rqt rqt_console rqt_graph rqt_gui rqt_gui_cpp rqt_gui_py rqt_msg rqt_plot rqt_publisher rqt_py_common rqt_py_console rqt_reconfigure rqt_service_caller rqt_shell rqt_srv rqt_top rttest rviz2 rviz_assimp_vendor rviz_common rviz_default_plugins rviz_ogre_vendor rviz_rendering rviz_rendering_tests rviz_visual_testing_framework sensor_msgs shape_msgs shared_queues_vendor sqlite3_vendor sros2_cmake std_msgs std_srvs stereo_msgs test_cli test_cli_remapping test_communication test_interface_files test_launch_testing test_msgs test_quality_of_service test_rclcpp test_ros2cli test_security tf2 tf2_eigen tf2_geometry_msgs tf2_kdl tf2_msgs tf2_ros tf2_sensor_msgs tinydir_vendor tinyxml2_vendor tinyxml_vendor tlsf tlsf_cpp topic_monitor trajectory_msgs uncrustify_vendor unique_identifier_msgs urdf urdfdom visualization_msgs yaml_cpp_vendor ```
dirk-thomas commented 5 years ago

I still have a hard time reading / understanding your diff. Anyway I addressed several cases in the referenced PRs based on a clean rebuild (using colcon/colcon-ros#79). Please feel free to ping me if you encounter any remaining - please with a simple, easy to read list :wink:

For any higher level packages (I only look up to a certain level of packages) please consider create PRs or tickets for them.

mikaelarguedas commented 5 years ago

Since the colcon_ros change causing this issue has been reverted, can this be closed? or is it kept to track the packages missing some files?

ruffsl commented 5 years ago

We can reopen this in the future if it resurfaces when the magic in colcon_ros is deprecated.