nightly and nightly-rmw are now the same + should we keep skipping opensplice rosdep keys?

osrf / docker_images

A repository to hold definitions of docker images maintained by OSRF

Apache License 2.0

557 stars 170 forks source link

nightly and nightly-rmw are now the same + should we keep skipping opensplice rosdep keys? #380

Closed mikaelarguedas closed 4 years ago

mikaelarguedas commented 4 years ago

Since CycloneDDS is in the ros2:nightly image and Opensplice is not in the nightly archives anymore.

ros2:nightly and ros2:nightly-rmw are now the same images.

We should either remove ros2:nightly-rmw or keep it but update the README accordingly.

Along with that we can revisit all the mentions of opensplice that remain:

In the skip-keys of nightly image:
- pro-removal: if the image is built witch default args, skipping the key is unnecessary as ROS 2 doesnt ship with opensplice anymore'
- con: anyone using an older archive will get libopensplice installed via rosdep while it was not the case before
In the source images Dockerfile
- pro/cons same as abobe, based on which distro people build from source they will or will not need to skip these keys

@ruffsl FYI

ruffsl commented 4 years ago

I'm a fan of cleaning up the skip these keys; as this is a nightly image. Folks using Dockerfiles to install other archives can fork to modify the default archive URL and add custom skipped keys.

We should either remove ros2:nightly-rmw or keep it but update the README accordingly.

Is CycloneDDS a default rmw? I was thinking we should instead correct the ros2:nightly tag to only install the current default, FastRTPS, then leave non-default (but not non-free) RMWs in ros2:nightly-rmw.

mikaelarguedas commented 4 years ago

Is CycloneDDS a default rmw?

It depends what the definition of default is..

From my perspective the "default" is whatever is used when I launch a node without specifying RMW_IMPLEMENTATION explicitly. So right now this is Fast-RTPS and not CycloneDDS.

The nightly archive includes ALL rmw__cpp packages. Only the system dependencies are not included. For opensplice is was the `libopensplice` package. Now both Fast-RTPS and CycloneDDS are built from source (no debs provided by vendor). So both of them are part of the nightly archive.

This means there is currently no "Not in the archive but open source" supported DDS implementations.

ruffsl commented 4 years ago

Now both Fast-RTPS and CycloneDDS are built from source (no debs provided by vendor). So both of them are part of the nightly archive.

Ah, gotcha. I was thinking it was still a separate deb.

Ok, are there still any other rwm implementations that could sit in the rmw tag, like that shared memory transport from Bosch?

mikaelarguedas commented 4 years ago

AFAICT there are only 3 RMWs in the archive: fastrtps, cyclonedds and connext and it looks like it'll stay like this for now based on the REP for foxy https://github.com/ros-infrastructure/rep/pull/217/files

iceoryx is not part of the repos file at the moment. And as under heavy development my guess is that is would be built from source and not installed from deb if it was one of the officially supported rmws

mikaelarguedas commented 4 years ago

Adressed in https://github.com/osrf/docker_images/pull/383