osrf / docker_images

A repository to hold definitions of docker images maintained by OSRF
Apache License 2.0
579 stars 172 forks source link

perception/simulation/desktop-full tags to new ros2 images #620

Closed mikaelarguedas closed 2 years ago

mikaelarguedas commented 2 years ago

Superseed https://github.com/osrf/docker_images/pull/619

keeping this as draft waiting for answers to https://github.com/osrf/docker_images/pull/620#discussion_r870638478 and https://github.com/osrf/docker_images/pull/619#issuecomment-1124132514 and make changes accordingly before placing in revier

tfoote commented 2 years ago

+1 for getting this in, waiting for @ruffsl 's review.

mikaelarguedas commented 2 years ago

Updated to add simulation and perception

@tfoote could you or the person in charge of Rolling ping here once these new variants have been synced to main? this is a prerequisite for the dockerfiles to be generated and not break CI by merging this

tfoote commented 2 years ago

I'll try to remember after the next syncs but also pinging release managers @audrow and @nuclearsandwich

audrow commented 2 years ago

@mikaelarguedas, is this PR waiting on anything before it can come out of draft status? It'd be nice to get this in just after the Humble sync on Monday the 23rd.

mikaelarguedas commented 2 years ago

It is waiting for a humble (and a rolling) sync to main. Those first syncs ideally happen during the last week of the beta phase of the distro. This gives time for the images to be submitted upstream and have time to build on all architectures. For example if the sync happens on the 23rd, the images will only be available around the 26th.

Do you know when the rolling and humble sync will happen?

mikaelarguedas commented 2 years ago

Waiting for the new variants to be unblocked by the rolling sync, a minimal PR adding humble images has been made separately at https://github.com/osrf/docker_images/pull/622 and submitted to the official docker images repos

audrow commented 2 years ago

Do you know when the rolling and humble sync will happen?

The Humble sync happened today, the next rolling sync should happen this week.

nuclearsandwich commented 2 years ago

https://discourse.ros.org/t/preparing-for-rolling-sync-2022-05-26/25731

mikaelarguedas commented 2 years ago

Upstream PR: https://github.com/docker-library/official-images/pull/12521